New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix field validations #2544
Merged
Merged
Fix field validations #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbruy
force-pushed
the
fix-validations
branch
from
February 2, 2023 08:49
d44d2ba
to
40319ac
Compare
tomasMizera
reviewed
Feb 2, 2023
This is a big change and needs proper testing -> let's have it in |
alexbruy
force-pushed
the
fix-validations
branch
from
February 2, 2023 14:18
40319ac
to
bfc7985
Compare
tomasMizera
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looking good :) Let's test this properly
@alexbruy can you rebase this branch please in order to have ios testing candidates? Thanks! |
alexbruy
force-pushed
the
fix-validations
branch
from
February 7, 2023 16:53
d00fb74
to
5550219
Compare
… page (#2532) * use invitations form the user info when populating manage invitations page * workaround: don't filter invitations without expiration date * address review
alexbruy
force-pushed
the
fix-validations
branch
2 times, most recently
from
February 15, 2023 11:57
76e926c
to
d8c62e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back field validations by storing value entered by the user as a "raw" value and running validations against this value instead of using value converted to the compatible form for the field.