Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field validations #2544

Merged
merged 11 commits into from Feb 15, 2023
Merged

Fix field validations #2544

merged 11 commits into from Feb 15, 2023

Conversation

alexbruy
Copy link
Contributor

@alexbruy alexbruy commented Feb 1, 2023

Bring back field validations by storing value entered by the user as a "raw" value and running validations against this value instead of using value converted to the compatible form for the field.

app/attributes/attributecontroller.cpp Outdated Show resolved Hide resolved
app/qml/editor/inputrangeeditable.qml Show resolved Hide resolved
app/attributes/fieldvalidator.cpp Outdated Show resolved Hide resolved
app/attributes/attributecontroller.h Outdated Show resolved Hide resolved
@tomasMizera
Copy link
Collaborator

This is a big change and needs proper testing -> let's have it in 2.1.0 instead

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good :) Let's test this properly

@tomasMizera
Copy link
Collaborator

@alexbruy can you rebase this branch please in order to have ios testing candidates? Thanks!

@alexbruy alexbruy changed the base branch from 2.1.0 to master February 14, 2023 12:19
@alexbruy alexbruy force-pushed the fix-validations branch 2 times, most recently from 76e926c to d8c62e0 Compare February 15, 2023 11:57
@alexbruy alexbruy merged commit 8721ce5 into master Feb 15, 2023
@alexbruy alexbruy deleted the fix-validations branch February 15, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move field value validation to setFormValue step in forms | Bring back numeric field validation
2 participants