Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Project Page #3036

Closed
wants to merge 7 commits into from
Closed

New Project Page #3036

wants to merge 7 commits into from

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Jan 31, 2024

image

Note: Upload icon is missing in the new design

Copy link

github-actions bot commented Jan 31, 2024

Pull Request Test Coverage Report for Build 7785146859

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 60.669%

Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.86%
input/app/projectsmodel.cpp 1 67.23%
input/app/mmstyle.h 17 0.0%
Totals Coverage Status
Change from base Build 7728354385: 0.03%
Covered Lines: 7543
Relevant Lines: 12433

💛 - Coveralls

@PeterPetrik
Copy link
Contributor

Can you add screenshots and rebase?

@@ -73,6 +81,35 @@ Item {
onClicked: root.backClicked()
}

Rectangle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct approach. Personal Icon should be bound from parent as right item

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss it. This is a special item and should be extended by the new design, it can contain a red mark on the top right corner of this icon or can contain user initials instead of the icon.

@iiLubos iiLubos marked this pull request as ready for review February 7, 2024 21:27
@PeterPetrik
Copy link
Contributor

closing this in favour of #3045

@PeterPetrik PeterPetrik deleted the master_projectList branch March 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants