Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download button #3298

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix download button #3298

merged 1 commit into from
Apr 11, 2024

Conversation

wonder-sk
Copy link
Contributor

Fixes #3206

Do not show download button while download is in progress... Debug build would crash on assert anyway.
This fixes the problem (1) and it should not be possible to get problems (2) and (3) anymore

recorder-2024-04-11_12.59.54.mp4

Copy link

Pull Request Test Coverage Report for Build 8645655393

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 60.065%

Files with Coverage Reduction New Missed Lines %
input/app/projectsmodel.cpp 1 65.75%
Totals Coverage Status
Change from base Build 8628227245: 0.008%
Covered Lines: 7582
Relevant Lines: 12623

💛 - Coveralls

@PeterPetrik
Copy link
Contributor

invisible button is not possible to press, right?
right?
right? :)

@PeterPetrik PeterPetrik merged commit fabbc5f into master Apr 11, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the fix-download-button branch April 11, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App freezes on Explorer page
2 participants