Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signet Ring Quest Reward Overhaul #151

Closed
wants to merge 2 commits into from
Closed

Signet Ring Quest Reward Overhaul #151

wants to merge 2 commits into from

Conversation

FSU-Phil
Copy link
Contributor

@FSU-Phil FSU-Phil commented Apr 5, 2013

This change is an overhaul of the Signet Ring Quest Reward table:

When you return a signet ring your chances (of getting 1 of below) are:
40% = Money (20-40k)
15% = Invis Ring + Money (5-10k)
15% = (25 Purps, or 25 Ents) + Money (5-10k)
10% = Rose
10% = (25 Inkies, or 25 Mints) + Money (5-10k)
5% = Random Sided Prism
5% = Random Mask Gift

This change is an overhaul of the Signet Ring Quest Reward table:

When you return a signet ring your chances are:
40% = Money (20-40k)
15% = Invis Ring + Money (5-10k)
15% = (25 Purps, or 25 Ents) + Money (5-10k)
10% = Rose
10% = (25 Inkies, or 25 Mints) + Money (5-10k)
5% = Random Sided Prism
5% = Random Mask Gift
Remove debug messages used to test the change.
else
{
Send(oMoney,@AddNumber,#number=iValue);
Debug("Signet Ring Reward did not meet criteria for ",who);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is unreachable as far as I can tell. Remove it.

@Serpentiel-zz
Copy link

+1

2 similar comments
@XYLUM
Copy link
Contributor

XYLUM commented Mar 21, 2014

+1

@Koveras
Copy link
Contributor

Koveras commented Jan 31, 2015

+1

cyberjunk pushed a commit to cyberjunk/meridian59-orig that referenced this pull request Jun 7, 2016
Add kod data type documentation.
@davidklaw
Copy link
Contributor

@FSU-Phil Still around? 🤔 Any interest in following up on this?

@davidklaw
Copy link
Contributor

trestype.kod still limits signet ring drops to players under the PFLAG_PKILL_ENABLE threshold. Is it odd to be handing out these types of rewards to new characters? Anything to make the signet ring quests more interesting or valuable under the current game economy is welcome in my opinion, but this seems a little extreme.

What about something like the reward table below? These seem like worthwhile rewards to support a new player or provide them with something unique and interesting to hang onto.

Probability Reward
90% 2,500-7,500 shillings
5% Plate armor
3% Jewel of Froz
1% Rose
1% Random mask gift

Adding dialog for these could be fun as well.

@davidklaw
Copy link
Contributor

If the original intent behind this PR is desired and @FSU-Phil is no longer around, I'd be happy to address the last request and submit a new one.

@akirmse
Copy link
Collaborator

akirmse commented Jul 2, 2022

Closing this, as no motivation is given for the change. We could start over if there's a need for a change,

@akirmse akirmse closed this Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants