New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signet Ring Quest Reward Overhaul #151
Conversation
This change is an overhaul of the Signet Ring Quest Reward table: When you return a signet ring your chances are: 40% = Money (20-40k) 15% = Invis Ring + Money (5-10k) 15% = (25 Purps, or 25 Ents) + Money (5-10k) 10% = Rose 10% = (25 Inkies, or 25 Mints) + Money (5-10k) 5% = Random Sided Prism 5% = Random Mask Gift
Remove debug messages used to test the change.
else | ||
{ | ||
Send(oMoney,@AddNumber,#number=iValue); | ||
Debug("Signet Ring Reward did not meet criteria for ",who); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is unreachable as far as I can tell. Remove it.
+1 |
2 similar comments
+1 |
+1 |
Add kod data type documentation.
@FSU-Phil Still around? 🤔 Any interest in following up on this? |
What about something like the reward table below? These seem like worthwhile rewards to support a new player or provide them with something unique and interesting to hang onto.
Adding dialog for these could be fun as well. |
If the original intent behind this PR is desired and @FSU-Phil is no longer around, I'd be happy to address the last request and submit a new one. |
Closing this, as no motivation is given for the change. We could start over if there's a need for a change, |
This change is an overhaul of the Signet Ring Quest Reward table:
When you return a signet ring your chances (of getting 1 of below) are:
40% = Money (20-40k)
15% = Invis Ring + Money (5-10k)
15% = (25 Purps, or 25 Ents) + Money (5-10k)
10% = Rose
10% = (25 Inkies, or 25 Mints) + Money (5-10k)
5% = Random Sided Prism
5% = Random Mask Gift