Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reblance: Wedding Ring #194

Merged
merged 1 commit into from Jul 7, 2022
Merged

Reblance: Wedding Ring #194

merged 1 commit into from Jul 7, 2022

Conversation

marksturm
Copy link
Contributor

The wedding ring is more a roleplayitem and was rarely used by the players, cause nobody knew about the defense boon before the game went open source. The item is simple overpowered on casters or hybrid-toons, with high agility, robe and cess-faction. Even a Purefighter will allways miss the caster/hybrid-toon over the half of the time.

Otherwise we had to create a perma "war-ring" which gives the same boon on offense.

The wedding-ring is more a roleplayitem and was rarely used by the players, cause nobody know the defense boon before the game went open source. The item is simple overpowered on casters, with high agility, robe and cess-faction. Even a Purefighter will allways miss the caster or even a hybrid-toon (even with half purecaster stats) over the half of the time.
@M59Gar
Copy link
Contributor

M59Gar commented Jun 17, 2013

This isn't accurate. Defense can't reduce offensive hit rate below 55%, so nobody is 'missing over half the time' - and that's with 1000 defense, which is very difficult to obtain under many circumstances. Furthermore, defense can be dropped tremendously by blind and hold, and plate armor comes with a -200 penalty. Not wearing plate armor is critical to hitting 1000 defense, but that also means when the player does get hit they will be taking much more damage. Former developers anticipated this and gave robes of the disciple a -10% weakness to all weapon attacks.

The balance between offense and defense is skewed pretty heavily toward offense. Offense is almost always 1000 for everyone, while defense is tough to even get past 700 for most characters (78% hit rate). Defense really does not need a nerf.

Plus having a 100 defense ring is a pretty interesting tension with resist rings, invis rings, and berzerker rings.

@marksturm
Copy link
Contributor Author

That is why i miss on my testserver arround half the time on my testtoons and im also able on the lifeservers to use EQ arround 5 ppl without getting interruped by any arrow. I would not push this change in if it were not OP with on some builds. Atleast we talk here about a wedding ring and not about a perma "defense ring" without any negative parts of wearing it, beside beeing married ;). Even the ring is allways available, cant break or cant be lost ín a death and als has no loads or timer on it. Like invisring or the other rings. That this ring was never an issue, was simple the fact that ppl didnt know about the boon of the ring. Now it is an issue.

@jnharton
Copy link

jnharton commented Jul 6, 2013

It would make sense to either make this simply a cosmetic item or to set conditions for its use, such as halving the bonus unless the married 'couple' are together (measured by distance or same area). Arguably, a roleplay item shouldn't offer any PK benefits in a game intended to be PK-centered. Maybe it shouldn't even exist. However, some condition relating to the 'married' bit seems like a reasonable compromise if the desire is to retain it and it's benefits.

@MorbusM59
Copy link

I'd rather be in favor of making rings normal armor items that don't poof. Except for the Invis ring obviously. I enjoy the idea of resistance rings, zerker rings and wedding rings (or maybe create a new ring with 100 defense that is called "ring of engagement" for the obvious Diablo reference and lovely ambiguity) all being permanent, basically allowing the player one additional layer of strategical equipment to compliment their build, as well as allowing high skill players to quickly switch on the fly. We could make them a lot rarer though, and only give them a medium to low chance to drop from boss mobs, similar in rarity to the necklace of jala.

@Koveras
Copy link
Contributor

Koveras commented Feb 1, 2015

+1 to Morbus' suggestions

cyberjunk pushed a commit to cyberjunk/meridian59-orig that referenced this pull request Jul 20, 2016
Add Tyras's new Tos rooms/city exit.
@davidklaw
Copy link
Contributor

@Meridian59 This PR removes the defensive buff given to the wearer of a wedding ring, if the wearer is either of the two users who first picked it up (presumably to be "wed"), effectively making it a pure cosmetic item. There's some good discussion in the comments about defensive rings, but that might be a topic completely separate from wedding rings. It's also a really friggin' old PR. Would you like to see the wedding ring neutralized or is this a candidate for closing?

{
% Add a small amount of defense. Only added as a defmod if the user is
% One of the original 2 users, and both user slots are filled.
return defense_power + viDefense_bonus;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this function orphans viDefense_bonus under classvars. I recommend removing that as well.

@akirmse
Copy link
Collaborator

akirmse commented Jul 4, 2022

I'm OK taking this if there are no objections.

@davidklaw
Copy link
Contributor

🚫 No objections found.

@akirmse akirmse merged commit 682ffcc into Meridian59:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants