Add custom item color in lists for magic weapons/items #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,6 +62,6 @@ void ColorsRestoreDefaults(void); | |||
| M59EXPORT HBRUSH DialogCtlColor(HWND hwnd, HDC hdc, HWND hwndChild, int type); | |||
| HBRUSH MainCtlColor(HWND hwnd, HDC hdc, HWND hwndChild, int type); | |||
|
|
|||
| WORD GetItemListColor(HWND hwnd, int type); | |||
| WORD GetItemListColor(HWND hwnd, int type, int flag); | |||
There was a problem hiding this comment.
Should be flags, not flag.
moved viObject_flags = APPLY_YES | GETTABLE_YES to wand.kod
moved viObject_flags = APPLY_YES | GETTABLE_YES from spellitem.kod to wands.kod
corrected flag to flags
|
both adjusted |
|
This would be a good addition for visual information and intuitive game play, currently there is no way to tell if an item is enchanted without clicking on the description, and would make for a nice visual if also combined with the game's colored lighting system. |
|
+1. this sounds like a great idea! |
MorbusM59
pushed a commit
to MorbusM59/Meridian59
that referenced
this pull request
Dec 11, 2016
Fix display of news articles and mail posted from Ogre client.
|
Seems like a positive change for the reasons described above, however, it's long out of date and the conflict with |
|
@Meridian59 Abandoned and a candidate for closure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality of Life improvement:
coded by skittles1
Any weapon with an enchantment (cursed, glow, holder, Colhorr weapon, enchant weapon etc.) will show up in a separate color in all lists. Currently this defaults to orange and can be set by the client with other list colors (Options -> Colors -> List boxes -> Magic items).
All weapons and any 'defense modifier' (armor, shields, robes, etc.) with an enchantment will show up in either orange, the default color, or whatever the user chooses.