Corrected the location of the client folder

[todasj]

The folders name is 'localclient' not 'client'.

[Daenks]

I have found that in order to properly use rooedit, you need to specify absolute, not relative paths. using the relative paths will seem to work, but will cause additional crashes.

[cyberjunk]

I have found that in order to properly use rooedit, you need to specify absolute, not relative paths. using the relative paths will seem to work, but will cause additional crashes.

I can confirm that an absolute path is required to make it fully work...
I think at least the image preview fails unless it's absolute.

[todasj]

I have no problem viewing wall textures using a relative path.

Opening roo's is causing the program to crash but that happens with both relative- and absolute paths.
I guess it might be my Windows 8 causing it, I have unfortunately no older windows version to try it on.

[cyberjunk]

I have no problem viewing wall textures using a relative path.

Sorry, I should have provided more info...

You CAN select "Editor" in the Menu and select "View wall textures" with a relative path and without a crash...

BUT the following crashes with a relative path but NOT with an absolute one:

1. Open map file
2. Open properties of a sector (Sectors mode)
3. Double click a texture in the list

See image of crash:
https://googledrive.com/host/0B-6rsj6uHlolV2ZGMjNQLUZiLXc/roomedit_error.PNG

[todasj]

Got it. I cannot get that far, I crash when I open the roo.

[Nagath]

I've always used absolute Path's. Worked under Win 2000 and Win XP. Sadly my old Laptop died yesterday...
Everywhere else I've Win 7 right now and there it always crashes if I try to open a .roo...
Error: http://imgur.com/4kK3g5x

[cyberjunk]

Nagath, is it possible you send or post me the whole error from the "Windows Event Log"?
Unfortunately your screenshot is missing the most important part - the crash offset.
I should be able to get us the line of code causing your crashes from this offset...

[cyberjunk]

Roomedit/textures.cpp - FindTextureByNumber() - line 224:

assert (WTexture!=NULL);
if (num == 0)
return NULL;

This is what is crashing for me when a ROO is loaded with unitialized BGFs (due to incorrect path).

It seems a simple solution is:

if (WTexture == NULL || num == 0)
return NULL;

After that I seem to be able to even load a ROO file with an unset BGF path

[Nagath]

Sure, the complete error is:

Problemsignatur:
Problemereignisname: APPCRASH
Anwendungsname: windeu32.exe
Anwendungsversion: 0.95.0.0
Anwendungszeitstempel: ad2e42e5
Fehlermodulname: StackHash_3559
Fehlermodulversion: 0.0.0.0
Fehlermodulzeitstempel: 00000000
Ausnahmecode: c0000005
Ausnahmeoffset: 6f722e31
Betriebsystemversion: 6.1.7601.2.1.0.256.4
Gebietsschema-ID: 1031
Zusatzinformation 1: 3559
Zusatzinformation 2: 35594fc7014e9b3c7e20ca69f25623a0
Zusatzinformation 3: 321f
Zusatzinformation 4: 321f24a13a840fe1ae71214e97c70ea8

Lesen Sie unsere Datenschutzbestimmungen online:
http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0407

Wenn die Onlinedatenschutzbestimmungen nicht verfügbar sind, lesen Sie unsere Datenschutzbestimmungen offline:
C:\Windows\system32\de-DE\erofflps.txt

[cyberjunk]

Thanks

Ausnahmeoffset: 6f722e31

That is what I was looking for.
Not at home right now, but will have a look which line it is when I get back home.

I would expect your errors are still BGF related, but we'll see.

[cyberjunk]

Fehlermodulname: StackHash_3559
Ausnahmeoffset: 6f722e31

Your crashdata looks a bit weird...
I can not find a module (or proper executable code) at the given crashoffset.
"StackHash_3559" probably says so, too.

I'm just going to make the rough assumption this could be related to issues with zlib1.dll

Please test the content of the following ZIP:
https://googledrive.com/host/0B-6rsj6uHlolV2ZGMjNQLUZiLXc/windeu_test.zip

1. windeu32_dynload.exe
   This is a windeu32.exe with the following modification: Rather than having the zlib linked at compilation time from the OMF converted lib file, it is fully dynamically loaded at execution time (MSDN: LoadLibraryEx+GetProcAddress).

2. zlib1_new.dll
   This is an up to date zlib library downloaded from http://www.zlib.net/

Now please try this:

1. Put the included windeu32_dynload.exe to your windeu32.exe directory and start it. Please let me know if this works better...

2. If it does not, please also try to replace the original (and very old/old linkersystem) zlib1.dll in the windeu directory with the included zlib1_new.dll (extract&rename).

---

PS: @Nagath : Can you at least go to "Menu (Editor)" -> "View Wall Textures" without issues and without trying to load any ROO at all?

---

PPS: Here is one more version in case the (1) and (2) above still fail:
https://googledrive.com/host/0B-6rsj6uHlolV2ZGMjNQLUZiLXc/windeu32_test2.zip

This one is almost like the original version, except that it has the mentioned change to the "assert (WTexture!=NULL);". Using this version I can even open a ROO file with a completely garbage bitmapdir in windeu.ini (warning at startup). The ROO gets loaded, but the app crashes sooner rather than later because of still missing BGF.

[Nagath]

"Menu (Editor)" -> "View Wall Textures" works without any issues, I have only the crash Problem if I try to open a .roo

[Nagath]

Just made an interessting observation. If I open .roo files out of my repo path it always crashes. But if I open the .roo files out of a copy of my game installation ressource directory it works without any problems...

[cyberjunk]

Interesting. What's your exact paths?
Because I can open ROO from both, the repository and the gameclient resource folder...

CLIENT: c:\meridian_101\resource
GIT-REPO: c:\meridian59-orig\resource\rooms

[Nagath]

bitmapdir = D:\MPL\M59\resource
bitmapspec = grd*.bgf
serverdir = D:\MPL\Meridian59-ENTW-master\run\server
koddir = D:\MPL\Meridian59-ENTW-master\kod\

The bitmapdir is a copy of my gaming resource directory

[cyberjunk]

Please have a look at this 103 pullrequest:
OpenMeridian#931

It contains several small fixes for the roomeditor probably worth adopting to 101, such as:
(1) cyberjunk@572487d
(2) cyberjunk@a32acd7

and more...

@broodhill : You may want to add them to this commit here...

[todasj]

Strange. I can also open roo-files from the 101 client but if I try to open a file from the repo it crashes.

[Meridian59]

This change looks fine ("client" is a historical local directory we used during development).

I'm happy to take other roomedit changes to fix crashes, too.