Bump oas-validator ajv dependency to 6.12.3 #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaslago
commented
Jul 30, 2020
| @@ -13,17 +13,16 @@ let ajv = require('ajv')({ | |||
| allErrors: true, | |||
| verbose: true, | |||
| jsonPointers: true, | |||
| patternGroups: true, | |||
There was a problem hiding this comment.
This option was removed on ajv-validator/ajv@e15f543
lucaslago
commented
Jul 30, 2020
| patternGroups: true, | ||
| extendRefs: true // optional, current default is to 'fail', spec behaviour is to 'ignore' | ||
| extendRefs: true, // optional, current default is to 'fail', spec behaviour is to 'ignore' | ||
| schemaId: 'id' |
There was a problem hiding this comment.
Following the instructions on using draft-04 per https://ajv.js.org/
|
Thanks, but I don't want to risk breaking things (e.g. in relation to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR bumps ajv to 6.12.3 with the intent of closing https://snyk.io/vuln/SNYK-JS-AJV-584908
I had to remove support for draft-05 meta schema due to support removal after draft-06 was released: https://json-schema.org/draft-06/json-schema-release-notes.html#q-what-happened-to-draft-05
I think this caused the author of ajv upstream to delete it on 6.0.0 release, so the meta schema import had to be updated.
According to the specification, draft-05 continued to use draft-04 meta schemas so I think this is a safe change: https://json-schema.org/specification-links.html#draft-5
closes #261