improved search results #2116
Merged
improved search results #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added mode for debug info
Grantim
reviewed
Jan 26, 2024
source/MRViewer/MRRibbonSchema.h
Outdated
Comment on lines
72
to
74
| float weight{ -1.f }; | ||
| float captionWeight{ -1.f }; | ||
| float tooltipWeight{ -1.f }; |
There was a problem hiding this comment.
not sure we want to store dynamic search information here
There was a problem hiding this comment.
better expand SearchResult struct
There was a problem hiding this comment.
also should these new field be under DEBUG def?
Grantim
approved these changes
Feb 1, 2024
| res.reserve( resultListForSort.size() ); | ||
| for ( const auto& sortedRes : resultListForSort ) | ||
| res.push_back( sortedRes.second ); | ||
| if ( !rawResult.empty() && rawResult[0].second.captionWeight < maxWeight / 3.f ) |
There was a problem hiding this comment.
please add comment for this block
| }; | ||
|
|
||
| const float maxWeight = 0.25f; | ||
| bool exactMatch = false; | ||
| auto checkItem = [&] ( const MenuItemInfo& item, int t ) |
There was a problem hiding this comment.
please add comment for this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added mode for debug info