-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved search results #2116
improved search results #2116
Changes from 3 commits
e350195
8419aa9
5bde45b
8d61c0d
9a275d0
1e9cc0f
0fd1072
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,9 @@ class MRVIEWER_CLASS RibbonSchemaHolder | |
{ | ||
int tabIndex{ -1 }; // -1 is default value if item has no tab | ||
const MenuItemInfo* item{ nullptr }; // item info to show correct caption | ||
float weight{ -1.f }; | ||
float captionWeight{ -1.f }; | ||
float tooltipWeight{ -1.f }; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure we want to store dynamic search information here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. better expand SearchResult struct There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also should these new field be under DEBUG def? |
||
}; | ||
MRVIEWER_API static std::vector<SearchResult> search( const std::string& searchStr ); | ||
private: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add comment for this function