Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused data files and move other data to data/ folder #20

Closed
bobturneruk opened this issue Nov 27, 2020 · 2 comments
Closed

Remove unused data files and move other data to data/ folder #20

bobturneruk opened this issue Nov 27, 2020 · 2 comments
Assignees
@Ankur-AVP-Patel
Projects
PGFinder Development

Comments

@bobturneruk
Copy link
Collaborator

No description provided.

@bobturneruk
Copy link
Collaborator Author

Maybe also come up with a consistent file naming strategy.

@bobturneruk bobturneruk moved this from To do to In progress in PGFinder Development Feb 2, 2021
@Ankur-AVP-Patel
Copy link
Collaborator

Old data files moved to /data/Legacy will review importance later and delete if necessary.

@Ankur-AVP-Patel Ankur-AVP-Patel moved this from In progress to Done in PGFinder Development Feb 6, 2021
ns-rse pushed a commit that referenced this issue Jan 10, 2024
@slackline
Fixing pytest-regtest issue
a58d889 
New releases of `pytest-regtest>=2.0.0` on PyPI are currently broken as the released packages don't appear to include
the Python code for the module itself. This has been reported upstream and when fixed I will remove the dependency.

+ [pytest-regtest #20](https://gitlab.com/uweschmitt/pytest-regtest/-/issues/20)

At the same time I've...

+ Made the `pre-commit` updates that were automated in #253 where the `pytest-regtest` issue cropped up
+ Added `no-commit-to-branch` check to `pre-commit` hooks which protects against commits to `master` locally.
+ Introduced `NPY201` checks under `ruff` linting to check for forthcoming Numpy2 deprecations.

Numpy2 is due to be released early later this year (first release candidate is scheduled 2024-02-01).

This may introduce some breaking changes, a broad overview is available [here](https://pythonspeed.com/articles/numpy-2/).

Mentioned in that article is that `scikit-image` has issues, which is indirect because the package has an optional
dependency on `matplotlib` (I've discovered this whilst working on `skan` issues).

The official [NumPy 2.0 migration guide — NumPy v2.0.dev0
Manual](https://numpy.org/devdocs/numpy_2_0_migration_guide.html) suggests that `ruff` can be leveraged to address the
mentioned changes under [Ruff Plugin](https://numpy.org/devdocs/numpy_2_0_migration_guide.html#ruff-plugin).

A useful summary of how to handle potential problems is provided at
[Numpy #24300](numpy/numpy#24300) and broadly suggests pinning `numpy<2.0` for releases whilst
development proceeds on resolving issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ankur-AVP-Patel Ankur-AVP-Patel

Labels
None yet
Projects
PGFinder Development
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobturneruk @Ankur-AVP-Patel