Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit automatically updated. #253

Closed
wants to merge 2 commits into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 1, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.9 → v0.1.11](astral-sh/ruff-pre-commit@v0.1.9...v0.1.11)
- [github.com/pre-commit/mirrors-eslint: v8.56.0 → v9.0.0-alpha.0](pre-commit/mirrors-eslint@v8.56.0...v9.0.0-alpha.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 98c81f2 to 17db13d Compare January 8, 2024 20:35
ns-rse pushed a commit that referenced this pull request Jan 10, 2024
New releases of `pytest-regtest>=2.0.0` on PyPI are currently broken as the released packages don't appear to include
the Python code for the module itself. This has been reported upstream and when fixed I will remove the dependency.

+ [pytest-regtest #20](https://gitlab.com/uweschmitt/pytest-regtest/-/issues/20)

At the same time I've...

+ Made the `pre-commit` updates that were automated in #253 where the `pytest-regtest` issue cropped up
+ Added `no-commit-to-branch` check to `pre-commit` hooks which protects against commits to `master` locally.
+ Introduced `NPY201` checks under `ruff` linting to check for forthcoming Numpy2 deprecations.

Numpy2 is due to be released early later this year (first release candidate is scheduled 2024-02-01).

This may introduce some breaking changes, a broad overview is available [here](https://pythonspeed.com/articles/numpy-2/).

Mentioned in that article is that `scikit-image` has issues, which is indirect because the package has an optional
dependency on `matplotlib` (I've discovered this whilst working on `skan` issues).

The official [NumPy 2.0 migration guide — NumPy v2.0.dev0
Manual](https://numpy.org/devdocs/numpy_2_0_migration_guide.html) suggests that `ruff` can be leveraged to address the
mentioned changes under [Ruff Plugin](https://numpy.org/devdocs/numpy_2_0_migration_guide.html#ruff-plugin).

A useful summary of how to handle potential problems is provided at
[Numpy #24300](numpy/numpy#24300) and broadly suggests pinning `numpy<2.0` for releases whilst
development proceeds on resolving issues.
@ns-rse
Copy link
Collaborator

ns-rse commented Jan 10, 2024

Updates applied via #255

@ns-rse ns-rse closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant