Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify protection level of UICollectionViewDataSource methods #177

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Modify protection level of UICollectionViewDataSource methods #177

merged 2 commits into from
Sep 28, 2017

Conversation

cwalo
Copy link
Contributor

@cwalo cwalo commented Sep 27, 2017

Making these methods open allows for more flexibility, but does have the potential for more user error when not used as intended.

@SD10 SD10 mentioned this pull request Sep 28, 2017
Merged
24 tasks
SD10
SD10 approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@SD10 SD10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👌

@cwalo cwalo merged commit 233d2c1 into MessageKit:v0.9.0 Sep 28, 2017
SD10 added a commit that referenced this pull request Oct 2, 2017
@SD10
[Changelog] Add changelog entries for #177, #175, #174
bca865c
@cwalo cwalo deleted the fix/collectionView-protection-levels branch October 6, 2017 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SD10 SD10 SD10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwalo @SD10