Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove analyzer VSIX #1114

Closed
AArnott opened this issue Nov 12, 2020 · 1 comment
Closed

Remove analyzer VSIX #1114

AArnott opened this issue Nov 12, 2020 · 1 comment
Assignees
@AArnott
Milestone
v2.3

Comments

@AArnott
Copy link
Collaborator

AArnott commented Nov 12, 2020

If removal of the analyzer VSIX project will enable building with dotnet build, let's remove the project.

Per the conversation below:

VSIX-deployed analyzers are something I think we can cut support for. Many people prefer the nuget deployed analyzers anyway. Thoughts?

Yes, I wish I could, but vsix is an easy alternative because it requires a hack to get Analyzer to work in Unity csproj.
but I think it can be removed.

Originally posted by @neuecc in #1108 (comment)
@pCYSl5EDgo
Copy link
Contributor

Unity 2020.2 provides the way to use roslyn analyzer without vsix.
I prefer nuget roslyn analyzer.
I want better development experience.

AArnott added a commit to AArnott/MessagePack-CSharp that referenced this issue Nov 13, 2020
@AArnott
Remove VSIX and use dotnet build in AzP
9e719ff 
Closes MessagePack-CSharp#1114
@AArnott AArnott mentioned this issue Nov 13, 2020
Merged
@AArnott AArnott self-assigned this Nov 13, 2020
@AArnott AArnott added this to the v2.3 milestone Nov 13, 2020
@AArnott AArnott closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
v2.3
Development

No branches or pull requests
2 participants
@AArnott @pCYSl5EDgo