Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNITY_STANDALONE in v2 is not a valid define on Unity #507

Closed
neuecc opened this issue Jul 22, 2019 · 3 comments · Fixed by #518
Closed

UNITY_STANDALONE in v2 is not a valid define on Unity #507

neuecc opened this issue Jul 22, 2019 · 3 comments · Fixed by #518
Assignees
@AArnott
Milestone
v2.0

Comments

@neuecc
Copy link
Member

neuecc commented Jul 22, 2019 •
edited

It means only for Standalone(Win, Mac, Linux) build.
We can use UNITY_5_3_OR_NEWER instead of it.
https://docs.unity3d.com/2018.3/Documentation/Manual/PlatformDependentCompilation.html
@AArnott AArnott added this to the v2.0 milestone Jul 22, 2019
@AArnott
Copy link
Collaborator

AArnott commented Jul 22, 2019

Thanks. I wasn't sure which preprocessor symbol was best to use.

@AArnott AArnott self-assigned this Jul 22, 2019
@AArnott
Copy link
Collaborator

AArnott commented Jul 23, 2019

Given our resolution to #508, I'm thinking I'll use the UNITY_2018_3_OR_NEWER symbol. Sound good, @neuecc?

AArnott added a commit to AArnott/MessagePack-CSharp that referenced this issue Jul 23, 2019
@AArnott
Use UNITY_2018_3_OR_NEWER for #if instead of UNITY_STANDALONE
6743b60 
Closes MessagePack-CSharp#507
This was referenced Jul 23, 2019
Merged
Closed
@neuecc
Copy link
Member Author

neuecc commented Jul 23, 2019

Yes, I'll check and merge it.
After it, about #508, we need to open new issue to remove some defines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Use UNITY_2018_3_OR_NEWER for #if instead of UNITY_STANDALONE AArnott/MessagePack-CSharp
2 participants
@AArnott @neuecc