Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared Projects have unexpected behavoiur in mpc #971

Closed
thorgeirk11 opened this issue Jul 5, 2020 · 0 comments
Closed

Shared Projects have unexpected behavoiur in mpc #971

thorgeirk11 opened this issue Jul 5, 2020 · 0 comments

Comments

@thorgeirk11
Copy link
Contributor

thorgeirk11 commented Jul 5, 2020 •
edited

Bug description

Shared projects are not accounted for correctly when mpc is processing a .csproj with shared projects.

Repro steps

  • Create a three project: Project1, Project2_Shared, Project3_unrelated.
  • Add a sheared project reference between Project1 and Project2_shared.
  • Add a dummy class with MessagePackObject to all three projects.
  • Run mpc -i Project1.csproj -o Generated.cs.

Expected: The Generated parser only contains the classes from Project1 and Project2_shared.
Actual: The Generated Parse contains all three classes. Which results in a compile error (Project3 class does not exist in Project1)

I have made a Repo with the setup required to reproduce the error: https://github.com/thorgeirk11/MessagePackIssue_SharedProjects

I have a PR #972 that should fix the issue but I am not entirely sure if it results in some side-effects
thorgeirk11 added a commit to thorgeirk11/MessagePack-CSharp that referenced this issue Jul 5, 2020
@thorgeirk11
Fix MessagePack-CSharp#971 Shared Projects are refernaced with '..\'
99ed13e 
A '..\' results in an incorrect root folder.
Allowing files outside the shared project to be included.
@thorgeirk11 thorgeirk11 mentioned this issue Jul 5, 2020
Merged
@AArnott AArnott closed this as completed in 97af9f8 Jul 5, 2020
AArnott added a commit that referenced this issue Jul 5, 2020
@AArnott
Merge pull request #972 from thorgeirk11/master
73b1d03 
Fix #971 Shared Projects incorrecly included.
This was referenced Jul 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thorgeirk11