Fix #971 Shared Projects incorrecly included. #972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #971
The issue was that shared projected are referenced with a
..\
E.g.
CollectDocument incorrectly parsed that as navigation up by one folder instead of the
SharedProject
folder.mpc -i C:\source\AllMyProjects\MsgPackProject.csproj
would call theIterateCsFileWithoutBinObj()
method with the pathC:\source\AllMyProjects\..\SharedProject.projitems
instead ofC:\source\AllMyProjects\SharedProject.projitems
This change calls Path.GetFullPath that resolves '..' to the actual path.