Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpc fixes and Generated.cs refresh #1004

Merged
merged 4 commits into from
Aug 16, 2020

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Aug 15, 2020

  • Fix TypeCollector's test of the wrong field
  • Fix mpc codegen for nested types (fixes mpc for nested types broken #1003)
  • Add codegen runs to Azure Pipelines (to make sure generated.cs stays current)
  • Update Generated.cs files (they'll never fall out of date again)

@AArnott AArnott added this to the v2.1 milestone Aug 15, 2020
@AArnott AArnott requested a review from neuecc August 15, 2020 00:22
@AArnott AArnott self-assigned this Aug 15, 2020
@AArnott AArnott force-pushed the mpcUpdates branch 2 times, most recently from 4caeb6b to 0bc96f6 Compare August 15, 2020 00:33
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@neuecc neuecc merged commit 56f91f2 into MessagePack-CSharp:master Aug 16, 2020
@AArnott AArnott deleted the mpcUpdates branch August 19, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mpc for nested types broken
2 participants