Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of non-public enums when using AllowPrivate resolvers #1031

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Fix handling of non-public enums when using AllowPrivate resolvers #1031

merged 2 commits into from
Sep 12, 2020

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Sep 9, 2020

Fixes #1025

@AArnott AArnott added this to the v2.1 milestone Sep 9, 2020
@AArnott AArnott requested a review from neuecc September 9, 2020 23:20
@AArnott AArnott self-assigned this Sep 9, 2020
neuecc
neuecc approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@AArnott AArnott merged commit a995f1b into MessagePack-CSharp:master Sep 12, 2020
@AArnott AArnott deleted the fix1025 branch September 14, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuecc neuecc neuecc approved these changes

Assignees

@AArnott AArnott

Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

Internal enums trip up StandardResolverAllowPrivate
2 participants
@AArnott @neuecc