Merge master into v2.2 branch #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizeTypelessExtension Fix deserialize typeless extension without typeless formatter specified
…erpreter use ExpressionTree.Compile(preferInterpretation: true) for Unity IL2CPP
Improve generation of generic formatters
…Type This was previously checking whether the declaring type of the member was a value type, not the member itself. This property doesn't seem to be used anywhere and so fixing it shouldn't break anything else (it doesn't impact the unit test results at all).
…to ctor args as type object If the value of a property of type int is used to populate a constructor argument of type object in deserialization then this is allowed by the constructor-matching code because it simply uses IsAssignableFrom as a check for compatability (and object IsAssignable from int) but when the IL is generated to pass an int value as an object, it has to be boxed in order for the code to be valid. See notes at MessagePack-CSharp#987 (comment) that demonstrate how to use the reproduce case to generate a dll that PEVerify can be run against to show that it was invalid before this change. I've added unit tests in this changeset for the fix but I suspect that the test runner would have difficulties executing the tests WITHOUT the fix as the ExecutionEngineError could tear down the process before the test runner could record it as a failure. However, if you were to use Debug Test on one of the tests that I've added but comment out the fix that I put into the DynamicObjectResolver then you would be able to see the ExecutionEngineError be caught by the debugger.
Remove dead code
…egenerate mpc - Ignore [MessagePackFormatter] type collect
Run net472 tests on mono
Box value types if passed to ctor args as type object
Minor grammar fix to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.