Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling nested generic types in code generation #1048

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Fix handling nested generic types in code generation #1048

merged 1 commit into from
Sep 24, 2020

Conversation

mayuki
Copy link
Contributor

@mayuki mayuki commented Sep 18, 2020

#1010 (comment)

This PR fixes an issue where code generation for nested generic types would result in incorrect code output.

AArnott
AArnott approved these changes Sep 24, 2020
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @neuecc Can you review as well?

@neuecc
Copy link
Member

neuecc commented Sep 24, 2020

good implementations and thanks for fully covered tests.

@neuecc neuecc merged commit 06eb6e1 into MessagePack-CSharp:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
source generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mayuki @neuecc @AArnott