Enable deserialization constructors to use parameter names that match their property names #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
requested changes
Sep 24, 2020
...sagePack.UnityClient/Assets/Scripts/Tests/ShareTests/DynamicObjectResolverConstructorTest.cs
Show resolved
Hide resolved
AArnott
changed the title
AArnott
requested changes
Sep 24, 2020
...sagePack.UnityClient/Assets/Scripts/Tests/ShareTests/DynamicObjectResolverConstructorTest.cs
Show resolved
Hide resolved
…ing key names and member names Preferrs string key if both found. Tests are also added.
nabeelsherazi
force-pushed
the
master
branch
from
5b30b11
to
8ec03d7
Compare
|
Thank you, I think it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was able to clean up the commits for the fixes I developed for the issue where MPC wasn't able to de/serialize objects with string key names that weren't the same as the member names. I believe this fixes issue #1016, and indeed, in my own use case, I am now able to successfully de/serialize objects with these characteristics. These changes do not break any existing behavior (see screenshot of all tests passing), and I have written a new test to check coverage of this case as well, which passes.
Let me know if everything looks good or if there's anything you want me to change.