Fix support of custom implementation of ICollection<T> #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed? |
|
@neuecc Since this adds new functionality I think we should retarget the PR to v2.2 (which I will ship just as soon as we have no open PRs or blocking issues for it). |
AArnott
approved these changes
Sep 27, 2020
|
Ok to target v2.2. |
…support non generics `ICollection<>`, `IDictioanry<,>` implemented custom type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1062, #836
IEnumerable,ICollectionICollection<>,IDictioanry<,>implemented custom typeICollectiontoIList. (ICollectiondoes not haveAddso can not support)IDictionary<,>thanICollection<>, I don't think this will be a breaking change,until now priorities were determined by<T>, <TKey, TValue>, so the Dictionary was determined by the Dictionary.