MessagePackSerializer.NonGeneric uses reflection directly on Unity IL2CPP #1087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently MessagePackSerializer.NonGeneric uses ExpressionTree.Compile to use Generics Serialize/Deserialize.
Compile does not work on AOT environment so uses
Compile(preferInterpretation:true)
on Unity IL2CPP(ENABLE_IL2CPP).This PR changes
Compile(preferInterpreation:true)
to use reflection directly(MethodInfo.Invoke).MethodInfo.Invoke
, therefore, it is better to use direct reflection in this scenarioFix for #869 (comment)
and fix for blocking scenario of SignalR Unity support dotnet/aspnetcore#12102 (comment)
I've checked Windows IL2CPP build run succsessfully.
Limitation
ref struct
can not use reflection(it will solve at .NET 6? dotnet/runtime#10057 ) soref MessagePackWriter
andref MessagePackReader
overload throwsNotSupportedException
.Note that this is not supported by ExpressionTree Interpreter either, so an exception will be throwed.