Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MessagePackWindow can not run mpc command #1109

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Conversation

neuecc
Copy link
Member

@neuecc neuecc commented Nov 11, 2020

After this commit 1586a4d
ToolCommandName was changed from dotnet-mpc to mpc.
MessagePackWindow invoke dotnet mpc that expect to install by global tools so does not work.

@AArnott
By the way, is don't use dotnet- for ToolCommandName the standard style?

@neuecc neuecc requested a review from AArnott November 11, 2020 08:01
@AArnott
Copy link
Collaborator

AArnott commented Nov 11, 2020

By the way, is don't use dotnet- for ToolCommandName the standard style?

For global tools, that's certainly true. I think for project-level installed tools that you'd have to use dotnet in front of the command name.
mpc may be either global or project level. It depends on how it is installed.

@neuecc neuecc mentioned this pull request Nov 12, 2020
@neuecc neuecc merged commit e03f2aa into master Nov 12, 2020
@neuecc neuecc deleted the fix-messagepackwindow branch November 12, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants