mpc fix, generate collect class name in nested enum. #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mpc generate duplicate class name in nested enum.
I've modified generated type name from
type.Name
totype.ToDisplayString(ShortTypeNameFormat).Replace(".", "_")
.It will generate
so solved.
Also csproj collector load duplicate version metadata such as
MessagePack.dll, Version 2.0.90
andMessagePack.dll, Version 2.0.80
.It will fail
GetTypeByMetadataName("MessagePack.MessagePackObjectAttribute")
.This PR includes there fix to distinc by file name.