Include file looping #387
Merged
Include file looping #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
force-pushed
the
361_include_file_looping
branch
from
0b9314c
to
97310aa
Compare
|
To get the deterministic output file working we need to add the hashing inside the cset cli, as that has the templated recipe. |
jfrost-mo
force-pushed
the
361_include_file_looping
branch
from
97310aa
to
4a80d08
Compare
jfrost-mo
force-pushed
the
307_sequential_plot_display
branch
from
f3a0cd4
to
ebf284c
Compare
jfrost-mo
force-pushed
the
361_include_file_looping
branch
from
4a80d08
to
35607e5
Compare
jfrost-mo
force-pushed
the
307_sequential_plot_display
branch
from
ebf284c
to
93e4902
Compare
jfrost-mo
force-pushed
the
361_include_file_looping
branch
2 times, most recently
from
2fc6fc2
to
8c16858
Compare
jfrost-mo
force-pushed
the
307_sequential_plot_display
branch
from
93e4902
to
dcb840d
Compare
jfrost-mo
force-pushed
the
361_include_file_looping
branch
4 times, most recently
from
6cc76df
to
3f5fc96
Compare
|
This is ready to go as soon as #379 is merged. (and it is reviewed) |
jfrost-mo
force-pushed
the
361_include_file_looping
branch
from
3f5fc96
to
d6fcccb
Compare
jfrost-mo
force-pushed
the
361_include_file_looping
branch
from
d6fcccb
to
9a0181d
Compare
jfrost-mo
force-pushed
the
307_sequential_plot_display
branch
from
4a497bf
to
7dbb3c0
Compare
Add tests for generate_pressure_level_constraint Test exception when filter_cubes returns multiple cubes Also tests the inner workings of the pressure constraint.
This is the result of an effort to make the plot ID deterministically generated though it became apparent this wasn't the right place to implement it. Make plot ID deterministically generated The plot ID is now the SHA256 hash of the recipe. As this is deterministic it will allow updating plots in other cycles. Revert to UUID for plot ID as hashing isn't working We can't hash the recipe there as the templating hasn't yet happened.
This allows it to be found more easily, and is isolated per cycle. Replace MASS script with simpler bash one Replace plots folder with dynamically created symlink
This cleans up the initial download of the raw data after each cycle.
jfrost-mo
force-pushed
the
361_include_file_looping
branch
from
9a0181d
to
4dd3dbb
Compare
Sylviabohnenstengel
approved these changes
Feb 21, 2024
|
@jfrost-mo I added date and validity time as subtitle to the plot operator on this branch. Please could you take a look as some of the tests fail with not allowing a leading zero in the format statement. I removed the leading 0 from the formatting for year, but need to keep them for month, day, hour and minute to allow for days between 1-9 etc in the timestamp. WIthout the 0 in the formatting we get the following tomestamp: |
jfrost-mo
commented
Mar 21, 2024
This means it will work for more than just time.
Merged
|
@JorgeBornemann will you be able to review this soon? |
|
Working on it. It will be ready on Monday. |
|
Thanks! :) |
|
Merging as a prerequisite of #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #379
Fixes #361
To Do