Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycling over validity time #395

Merged
merged 92 commits into from
Apr 9, 2024
Merged

Cycling over validity time #395

merged 92 commits into from
Apr 9, 2024

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Feb 15, 2024

Based on #387

Fixes #322

To do

Copy link
Contributor

github-actions bot commented Feb 15, 2024

Coverage

@jfrost-mo jfrost-mo force-pushed the 322_cycling_over_validity_time branch from 11c5e9f to f284625 Compare February 15, 2024 14:36
@jfrost-mo

This comment was marked as resolved.

@jfrost-mo jfrost-mo changed the base branch from main to 361_include_file_looping February 15, 2024 14:39
@jfrost-mo jfrost-mo force-pushed the 322_cycling_over_validity_time branch 2 times, most recently from 4dfb37c to 57a4349 Compare February 16, 2024 11:18
@jfrost-mo

This comment was marked as resolved.

@jfrost-mo jfrost-mo force-pushed the 322_cycling_over_validity_time branch 2 times, most recently from fe9c469 to 0edfd5d Compare February 19, 2024 17:25
This command derives the ID from the title of the recipe _after_ templating
has taken place.
@jfrost-mo jfrost-mo force-pushed the 322_cycling_over_validity_time branch from 0edfd5d to 3f2c4ae Compare February 23, 2024 12:09
@jfrost-mo jfrost-mo force-pushed the 322_cycling_over_validity_time branch 3 times, most recently from 7e04d52 to ffb4975 Compare March 12, 2024 15:19
cset-workflow/flow.cylc Outdated Show resolved Hide resolved
This means the include files only need to contain the runtime sections
for the recipes. In future we might even be able to avoid that.
It requires quite a lot of extra per-filename setup, which is only
needed for large runs.
This means that adding a new recipe does not need to touch flow.cylc

Fixes #460

This required adding a glob jinja global, and fixing some workflow
loops caused by certain recipes.
@jfrost-mo jfrost-mo added the enhancement New feature or request label Mar 28, 2024
Break out workflow running commands into code blocks

Fixes #236
On the front page of the docs and the README. Code dates can be done when
those files are next changed.
Strings must be quoted in Jinja
Copy link
Collaborator

@JorgeBornemann JorgeBornemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve. Good change that improves massively the CSET capabilities. There are a few comments to take into account, but if needed can be taken into a future issue.

src/CSET/recipes/__init__.py Show resolved Hide resolved
src/CSET/operators/write.py Show resolved Hide resolved
src/CSET/operators/__init__.py Show resolved Hide resolved
docs/source/usage/workflow-installation.rst Show resolved Hide resolved
docs/source/usage/workflow-installation.rst Outdated Show resolved Hide resolved
cset-workflow/flow.cylc Show resolved Hide resolved
cset-workflow/flow.cylc Show resolved Hide resolved
cset-workflow/flow.cylc Show resolved Hide resolved
jfrost-mo and others added 2 commits April 8, 2024 15:40
Co-authored-by: JorgeBornemann <32248422+JorgeBornemann@users.noreply.github.com>
@jfrost-mo jfrost-mo mentioned this pull request Apr 9, 2024
1 task
Base automatically changed from 361_include_file_looping to main April 9, 2024 09:01
@jfrost-mo
Copy link
Member Author

With all the comments now being address, or moved out into seperate issues, I'll go ahead and merge this. I'm aiming to get a release out next week, which should give us time to clean up any last bit from this.

@jfrost-mo jfrost-mo merged commit 8ed85c6 into main Apr 9, 2024
8 checks passed
@jfrost-mo jfrost-mo deleted the 322_cycling_over_validity_time branch April 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling multiple sets of data in cylc top level
2 participants