Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V03 issue752 2 flowcb/scheduled was not working with the *scheduled_hours* setting. re-written to address that and other issues. #754

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

petersilva
Copy link
Contributor

fixing #752

  • it now works for multiple hours in the day.
  • it is based on building a list of appointments, once per day, then waiting until each one.
  • code now uses python datetime module using datetime, time, and timedeltas (like sarracenia durations.) datatypes.
  • notice that housekeeping doesn't run when waiting ... hmm... desirable or not?
  • output much clearer now.

Also:

  • added support to interrupt sleeps for housekeeping intervals, so that happens now.

 * it now works for multiple hours in the day.
 * it is based on building a list of appointments, once per day,
   then waiting until each one.
 * notice that housekeeping doesn't run when _waiting_ ... hmm...
   desirable or not?
 * output much clearer now.
@petersilva
Copy link
Contributor Author

@gcglinton you might want to try adding unit test to this branch? the new implementation is much easier to test.

@petersilva petersilva changed the title V03 issue752 2 V03 issue752 2 flowcb/scheduled was not working with the *scheduled_hours* setting. re-written to address that and other issues. Sep 1, 2023
remove documentation of limitations that have been resolved.
Copy link
Contributor

@tysonkaufmann tysonkaufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - unit testable - Peter has confirmed functionality

@petersilva petersilva merged commit cedc037 into v03_wip Sep 11, 2023
4 checks passed
@petersilva petersilva deleted the v03_issue752_2 branch September 27, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants