Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to basic_publish and improve logging #732 #761

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

reidsunderland
Copy link
Member

This makes some improvements but doesn't fix 732 yet.

It adds a timeout to publishing messages, which might help prevent hangs and improve error recovery when a broker isn't working. If the publish times out, it will raise an exception instead of hanging. The additional logging also helps troubleshooting - it was unclear where the publishing was getting stuck before.

The only thing missing is adding a timeout to the self.channel.tx_commit() call. We had talked about doing something similar to how timeouts are implemented here:

def alarm_raise(n, f):

#732 (comment)

@petersilva petersilva merged commit 5b4228c into v03_wip Oct 2, 2023
21 of 23 checks passed
@petersilva petersilva deleted the v03_wip_issue732 branch October 23, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants