Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue808 setup on start #814

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

petersilva
Copy link
Contributor

@petersilva petersilva commented Nov 7, 2023

hey @andreleblanc11 ... maybe try this branch... I put the putSetup() in a on_Start in sarracenia/flowcb/post/message.py ... so it should solve the
bind before declare problem in any component.

closes #808

@andreleblanc11
Copy link
Member

andreleblanc11 commented Nov 8, 2023

The changes are working. sr3 cleanup is working as it's supposed too.

A comment not really related to this issue, I'm not sure why we have putSetup placed in the cleanup routine. putSetup tries to connect to the broker (which is already done by getSetup) and then declares the exchange. Everytime I run cleanup, the exchange gets declared before getting deleted.

leblanca@edcm-dirt22-3:~/.config/sr3$ sr3 cleanup poll/test_issue808.conf
cleanup: 2023-11-08 13:27:39,329 590239 [INFO] sarracenia.moth.amqp getCleanUp deleting queue q_tfeed.poll.test_issue808.edcm-dirt22-3.edc-mtl.ec.gc.ca
 remove q_tfeed.poll.test_issue808.edcm-dirt22-3.edc-mtl.ec.gc.ca from xs_tfeed_test subscribers: ['q_tfeed.poll.test_issue808.edcm-dirt22-3.edc-mtl.ec.gc.ca']
No local queues found for exchange xs_tfeed_test, attemping to remove it...
2023-11-08 13:27:39,340 590239 [INFO] sarracenia.moth.amqp putSetup exchange declared: xs_tfeed_test (as: amqp://bunnymaster@localhost/)
2023-11-08 13:27:39,353 590239 [INFO] sarracenia.moth.amqp putCleanUp deleted exchange: xs_tfeed_test

Declaring the exchange agasin is harmless but just doesn't seem to make sens in the logic of things for a cleanup

@andreleblanc11
Copy link
Member

The last 4 dynamic flow tests are failing, I'm not sure if this can be ignored

@petersilva
Copy link
Contributor Author

for the two questions:

  • the only entry point to connect to the broker is *Setup (either put or get)... so in order to delete the queue, you need to connect to it, that's why the setup is called. the declare is a side effect. One could alter settings on the call to remove the declareQueue setting... before calling putSetup.
  • the last four are related to C components... I have ideas, but I don't know what's wrong... yes, hi on the list to investigate.

@petersilva
Copy link
Contributor Author

also note: the "normal" flow tests are passing ... here... it's the redis and MQTT ones that are broken... they are known broken... getting them to pass again is a project...

@andreleblanc11
Copy link
Member

I think we're good to merge

@andreleblanc11 andreleblanc11 merged commit 88f2a98 into development Nov 8, 2023
35 of 50 checks passed
@petersilva petersilva deleted the issue808_setup_on_start branch November 8, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sr3 start poll/* does not create exchanges when they are missing
2 participants