Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue828 - log message printing the wrong exchange. #830

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Conversation

petersilva
Copy link
Contributor

@andreleblanc11 ran into a case where it became obvious that when a component is subscribing and republishing, the post message prints the name of the exchange the message was received from, rather than the one it was posted to.

@andreleblanc11
Copy link
Member

Weird that so many of the flow tests are failing..

The changes look good. I'm not sure why you've added 09c769f#diff-b63c7bafd4f6cea2e9dab58f12ac8113a0b60da6f12077c3680506c56cb89d1eR684

@petersilva
Copy link
Contributor Author

what part of the commit is mysterious? ...

  • the exchange to be posted to isn't just the direct result of a "post_exchange" setting, if post_exchange_split is active, it will pick a different exchange, guided by message content.
  • So rather than use the setting self.o.post_exchange, set a private variable (a header that will not be forwarded) in the message to say where we actually published the message: message['post_exchange']
  • have the log routine use that.

@andreleblanc11
Copy link
Member

Yes you're right. I've skimmed by the changes too quickly.. oops

@petersilva
Copy link
Contributor Author

OK, @andreleblanc11 blessed it so merging.

@petersilva petersilva merged commit 60bbc94 into development Nov 17, 2023
4 checks passed
@petersilva petersilva deleted the issue828 branch November 17, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log message after_post prints reception exchange instead of transmission.
2 participants