Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits to Playbooks and Guilds pages #1753

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

Innkeeping
Copy link
Contributor

@Innkeeping Innkeeping commented Jun 24, 2024

Overview

What features/fixes does this PR include?
Fixes the url for daos playbook from 'das'. Added descriptions for all the playbooks that are more than Some text, some text, some text.

Removes the repetitive "Barrier of Entry: Coming soon" on every Guild card since they were inserted onto the page. The tiles themselves act as a link so not sure need the Contact:website also? The Website icon does not go to their websites. You then go to MG guild page for them and their are social links. So the bottom of the tiles are unnecessary.

Please provide the GitHub issue number
Not sure there is one.

Closes #

Follow up Improvement Ideas

  • Make descriptions appear as hover over text on playbooks without having to leave main academy page.
  • Update all the guild pages, make better workflow for adding new guilds

Copy link

vercel bot commented Jun 24, 2024

@Innkeeping is attempting to deploy a commit to the MetaFamily Team on Vercel.

A member of the Team first needs to authorize it.

@Innkeeping
Copy link
Contributor Author

Innkeeping commented Jun 24, 2024

@dysbulic
Can you give this a quick review to merge? Please and thank you.

@Innkeeping Innkeeping changed the title Updated urls and descriptions Minor edits to Playbooks and Guilds pages Jun 24, 2024
Copy link
Member

@dysbulic dysbulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cursory check saw no issues.

@dysbulic dysbulic merged commit 6cd8fd3 into MetaFam:develop Jun 24, 2024
10 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants