Reading and Writing Profile Info From Ceramic #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/metafam/the-game/EhannHLwrRuMEv938kZQ4bjnNYSG [Deployment for ed53f5e failed] |
|
Reopening to try & trigger the Google test instances. |
|
¿Does this work? |
dysbulic
force-pushed
the
feat/glaze-lookup
branch
from
fa82c7a
to
66bfa5d
Compare
|
Another reopen since the Google checks are running now that I've rebased it. |
|
& open… |
|
Reopening again for that Googlely goodness… |
|
¡Et, voila! |
|
Kick down with the database manually removed. |
|
Kick up. 😸 |
dysbulic
force-pushed
the
feat/glaze-lookup
branch
from
05c333f
to
dbe9edb
Compare
|
Successfully undeployed the Preview of this Pull Request |
This was referenced Jan 26, 2022
Merged
tenfinney
pushed a commit
that referenced
this pull request
Mar 1, 2022
This is being merged for further testing so as to not block the progress of `develop` & not require more rebases.
alalonde
pushed a commit
that referenced
this pull request
Mar 12, 2022
This is being merged for further testing so as to not block the progress of `develop` & not require more rebases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What features/fixes does this PR include?
This pull request does these primary things:
basicProfileand an extended profile document (Save profile information to the Ceramic network #920)Follow up Improvement Ideas
react-form-hook.Implementation
Describe technical (nontrivial / non-obvious) parts of your code
The main thing this PR does is it moves all the profile fields into their own table and defines the appropriate types for accessing them.
Side effects
The biggest side effects are from the fact that I standardized all the variable names as camel case when migrating them. The most pernicious was
timeZone, which despite being two words was a mishmash of capitalizations.