Enforce chainId #324
Merged
Enforce chainId #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20b0adb.
rekmarks
requested changes
Jan 15, 2021
Comment on lines
+15
to
+21
| mainnet = '1', | ||
| kovan = '42', | ||
| rinkeby = '4', | ||
| goerli = '5', | ||
| ropsten = '3', | ||
| localhost = '', | ||
| rpc = '', |
There was a problem hiding this comment.
Could we store these in hexadecimal instead?
Possibly related: #326
There was a problem hiding this comment.
oh wait, this would need a migration as well
There was a problem hiding this comment.
for transactions, I'd put that together with the work on the tx controller
There was a problem hiding this comment.
We decided to do this in a follow-up.
3 tasks
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* chainif * txcontroller * not default * mutex * test * Revert "mutex" This reverts commit 20b0adb. * tests * fulltest * format * comments
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* chainif * txcontroller * not default * mutex * test * Revert "mutex" This reverts commit 20b0adb. * tests * fulltest * format * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that all custom rpc networks have a valid chainId, and disregard the usage of networkId in favor of chainId