Allow for speedUp and stop based on provided gasValues from consumer #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
dynamic-speed-up
branch
from
9685c6b
to
4c048ff
Compare
rickycodes
force-pushed
the
dynamic-speed-up
branch
from
4c048ff
to
77398c3
Compare
rickycodes
commented
Jul 27, 2021
src/util.ts
Outdated
| const keys = Object.keys(gasValues); | ||
| keys.forEach((key) => { | ||
| const val = (gasValues as any)[key]; | ||
| if (typeof val !== 'string' || !isHexString(val)) { |
There was a problem hiding this comment.
technically this typeof check is redundant since you can't set these values to anything other than string. That said, I don't think it hurts to have an additional check.
Gudahtt
reviewed
Aug 2, 2021
Gudahtt
reviewed
Aug 2, 2021
…to dynamic-speed-up * 'dynamic-speed-up' of github.com:MetaMask/controllers: Bump @metamask/auto-changelog from 2.4.0 to 2.5.0 (#549) Update Changelog (#548) 14.0.2 (#547) Fix `resetPolling` functionality (#546) TokenService improvements (#541) Release/14.0.1 (#545) Make gweiDecToWEIBN util resilient against params with too many decimals (#544) Bump @metamask/contract-metadata from 1.27.0 to 1.28.0 (#540) 14.0.0 (#539) Bug: Mainnet NFT Autodetect API (#536)
ensure tx is increased by at least the minimum required amount
Gudahtt
reviewed
Aug 5, 2021
|
Thanks @Gudahtt! I've added the validation in |
Gudahtt
reviewed
Aug 10, 2021
Gudahtt
reviewed
Aug 10, 2021
|
@Gudahtt fixed spelling and removed unnecessary optional chaining |
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…535) * Allow for speedUp and stop based on provided gasValues from consumer * make this optional * validate gas values are hex string * use util * rename * update wording * Update tests * remove return true * Use type predicate functions * Move type predicate functions to util * Update unit tests * Add validation ensure tx is increased by at least the minimum required amount * Add validateMinimumIncrease method * Address nit * Add validation in stopTransaction * fix spelling * remove unnecessary optional chaining * test
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…535) * Allow for speedUp and stop based on provided gasValues from consumer * make this optional * validate gas values are hex string * use util * rename * update wording * Update tests * remove return true * Use type predicate functions * Move type predicate functions to util * Update unit tests * Add validation ensure tx is increased by at least the minimum required amount * Add validateMinimumIncrease method * Address nit * Add validation in stopTransaction * fix spelling * remove unnecessary optional chaining * test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening this as a draft as it relies on #521this adds a new interface
GasValueswhich can be used to dynamically set values forspeedUpandstopTransactionwhich can be used instead of our previously existing fixed rates.this will allow consumers to set custom gas values (in hex) for both those actions.