Consolidate token list controller data #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn same token type regardless of static or dynamic from token list controller.
…r tests. Add util test for converting logo to URL.
…eturn with ABSOLUTE file paths. Client side will need to be aware of that.
…nflict with TokenRateController.
…mprovement/consolidate-token-list-controller-data
…mprovement/consolidate-token-list-controller-data
rickycodes
requested changes
Jul 29, 2021
Cal-L
force-pushed
the
improvement/consolidate-token-list-controller-data
branch
from
a17df03
to
6ef6fbe
Compare
rickycodes
reviewed
Jul 30, 2021
rickycodes
force-pushed
the
improvement/consolidate-token-list-controller-data
branch
from
f62e3b7
to
f2fb9e8
Compare
rickycodes
previously approved these changes
Jul 30, 2021
Gudahtt
reviewed
Jul 30, 2021
rickycodes
force-pushed
the
improvement/consolidate-token-list-controller-data
branch
from
2227f55
to
b90f0e2
Compare
…ttps://github.com/MetaMask/controllers into improvement/consolidate-token-list-controller-data
…mprovement/consolidate-token-list-controller-data
Gudahtt
reviewed
Aug 2, 2021
…mprovement/consolidate-token-list-controller-data
…mprovement/consolidate-token-list-controller-data
Gudahtt
reviewed
Aug 5, 2021
Gudahtt
reviewed
Aug 5, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Add utils function to convert contract metadata logo to iconUrl. Return same token type regardless of static or dynamic from token list controller. * Provide ContractMap type for legacy tokens. Update TokenListController tests. Add util test for converting logo to URL. * Provide root path for TokenListController. NOTE: Static tokens will return with ABSOLUTE file paths. Client side will need to be aware of that. * Export Token as TokenListToken from TokenListController to prevent conflict with TokenRateController. * Clean up TokenListController. Update static logo path. * Clean up TokenListController. Fix TokenListController tests. * Fix github actions linting * Fix more github actions linting * Fix even more github actions linting * Fix last github actions linting * Allow for more time for token list controller API calls before timeout * Fix linting error * Add back newline to EOF package.json * Update contract metadata version * Up token list timeout to 10s * Update split logic * Add getFileExt utility and test * Add back caret to contract-metadata * Update description for fetchFromCache function * Remove iconPath * Remove unused enum & comment Co-authored-by: Ricky Miller <ricky.miller@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Add utils function to convert contract metadata logo to iconUrl. Return same token type regardless of static or dynamic from token list controller. * Provide ContractMap type for legacy tokens. Update TokenListController tests. Add util test for converting logo to URL. * Provide root path for TokenListController. NOTE: Static tokens will return with ABSOLUTE file paths. Client side will need to be aware of that. * Export Token as TokenListToken from TokenListController to prevent conflict with TokenRateController. * Clean up TokenListController. Update static logo path. * Clean up TokenListController. Fix TokenListController tests. * Fix github actions linting * Fix more github actions linting * Fix even more github actions linting * Fix last github actions linting * Allow for more time for token list controller API calls before timeout * Fix linting error * Add back newline to EOF package.json * Update contract metadata version * Up token list timeout to 10s * Update split logic * Add getFileExt utility and test * Add back caret to contract-metadata * Update description for fetchFromCache function * Remove iconPath * Remove unused enum & comment Co-authored-by: Ricky Miller <ricky.miller@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
TokenListControllershould consolidate all tokens regardless of static or dynamic into one data type:TokenListTokenTokenListControllerreturns a file name from static tokens and URLs from dynamic tokens.TokenListControllershould split the images field into two separate propertiesiconPathfor static tokens andiconUrlfor dynamic tokens.Resolves/Changes
TokenListTokentype. The idea was already there but I mapped it more, addedaddress,occurrences, andaggregators.TokenListTokentype fromTokenListControllerfor use in the appsTokenListControllertests