Mock all network requests

[mcmire]

Explanation

By default HTTP requests are allowed to be made in tests. Because
requests are not guaranteed to succeed, this can cause intermittently
failing CI builds, forcing engineers to wait until PRs are ready to
merge.

This commit addresses this problem by enabling Nock globally and then
modifying each test that hits the network to create proper mocks. This
was somewhat difficult to do with the assets controller tests as they
involve interactions with smart contracts on Mainnet.

Also, Nock was upgraded to 13.3.x, as without this change,
nock.recorder, used for debugging, was not working correctly.

References

Fixes #1
Fixes #770.
Fixes #769
Fixes #771
Fixes #773

Changelog

(N/A)

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
nock	13.3.1	network, filesystem, environment	+12	322 kB	nockbot

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: propagate@2.0.1, json-stringify-safe@5.0.1, nock@13.3.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

[legobeat]

@SocketSecurity ignore propagate@2.0.1
@SocketSecurity ignore json-stringify-safe@5.0.1
@SocketSecurity ignore nock@13.3.1

[legobeat]

Very nice improvement! Looks great.

[Gudahtt]

LGTM!