Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated eth-json-rpc-provider README content #1847

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Remove outdated eth-json-rpc-provider README content #1847

merged 1 commit into from
Oct 16, 2023

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Oct 16, 2023 •
edited
Loading

Explanation

  • Removes content in eth-json-rpc-provider README that is no longer relevant due to its migration as a non-root package in the monorepo.
  • During future migrations, this step should be performed while the package is in merged-packages/.
  • TODO: Restore links to GitHub Pages docs once the publish-docs workflows are set up in core.

References

Changelog

@metamask/eth-json-rpc-provider

  • CHANGED: Removed outdated README contents.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift
Remove eth-json-rpc-provider README content that is out-of-date aft…
ee5dbab 
…er migration.

- Add links to github pages docs once it's set up in core.
  - See #1845
@MajorLift MajorLift self-assigned this Oct 16, 2023
@MajorLift MajorLift requested a review from a team as a code owner October 16, 2023 20:47
mcmire
mcmire approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MajorLift MajorLift merged commit 8174a87 into main Oct 16, 2023
111 checks passed
@MajorLift MajorLift deleted the 231016-update-readme-eth-json-rpc-provider branch October 16, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove eth-json-rpc-provider README content that is out-of-date after migration.
2 participants
@MajorLift @mcmire