Release/148.0.0 #4260
Merged
Release/148.0.0 #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
May 6, 2024
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
May 6, 2024
Gudahtt
reviewed
May 6, 2024
Gudahtt
reviewed
May 6, 2024
Gudahtt
reviewed
May 6, 2024
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
approved these changes
May 6, 2024
|
Sorry thought I spotted a problem there, but I misread something. Ignore the dismissal and re-approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metamask/selected-network-controller
[13.0.0]
Changed
getProviderAndBlockTrackernow returns theNetworkController's globally selected network client proxy if thedomainarg is eithermetamaskor a snap (identified as starting withnpm:orlocal:) (#4259)setNetworkClientIdForDomainis called with a snap's domain (identified as starting withnpm:orlocal:), thedomainwill not be added to state and no proxy will be created for this domain in thedomainProxyMap(#4258)domainsstate prior to this change, consumers will need to run a migration.