Conversation
adonesky1
requested review from
a team,
FrederikBolding,
Gudahtt,
mcmire and
shanejonas
Member
|
Hmm, I think this is better categorized as a change, and we should document that it requires a migration as well (i.e. that it's breaking). The previous behavior wasn't really broken, at least not at the controller API level. |
…troller-domains-state
adonesky1
deleted the
ad/fix/exclude-snaps-from-selectedNetworkController-domains-state
branch
Merged
adonesky1
added a commit
that referenced
this pull request
May 6, 2024
# @metamask/selected-network-controller ## [13.0.0] ### Changed - `getProviderAndBlockTracker` now returns the `NetworkController`'s globally selected network client proxy if the `domain` arg is either `metamask` or a snap (identified as starting with `npm:` or `local:`) ([#4259](#4259)) - **BREAKING:** Now when `setNetworkClientIdForDomain` is called with a snap's domain (identified as starting with `npm:` or `local:`), the `domain` will not be added to state and no proxy will be created for this domain in the `domainProxyMap` ([#4258](#4258)) - In order to remove snaps that made it into `domains` state prior to this change, consumers will need to run a migration. --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently Snaps should not be included in the
SelectedNetworkController'sdomainsstate since they have no way of changing their network (they cannot callwallet_switchEthereumChainand have no UI exposed to manually switch their connected chain). This means that with theuseRequestQueuetoggle on they are stuck permanently connected to whatever chain is selected when they are installed.References
Changelog
@metamask/selected-network-controllerSelectedNetworkControllerChecklist