Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseControllerV2 support to ComposableController #447

Merged
merged 3 commits into from
Apr 22, 2021

Commits on Apr 19, 2021

  1. Add BaseControllerV2 support to ComposableController

    The ComposableController now supports controllers that are based upon
    BaseControllerV2. These newer controllers use the controller messaging
    system to communicate, so the messenger is now a required constructor
    parameter if any BaseControllerV2 controllers are used.
    
    The `name` property in `BaseControllerV2` had to be made public for the
    ComposableController to properly construct its state. This seems OK. It
    was only kept private initially until a use was found for it.
    Gudahtt committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    6ee460f View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Add additional documentation

    Gudahtt committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    089ae86 View commit details
    Browse the repository at this point in the history
  2. Remove ComposableController generic type parameters

    These generic type parameters weren't really used in practice. They
    were passed to the `messagingSystem`, but we erased the type of the
    messaging system in the one place that we call it, making the more
    specific types pointless. You can tell that they weren't useful because
    they were never set in tests, and everything still worked.
    Gudahtt committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    b1772f2 View commit details
    Browse the repository at this point in the history