Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Circle CI and storybook builds for PRs #105

Merged
merged 6 commits into from
May 4, 2022
Merged

Adding Circle CI and storybook builds for PRs #105

merged 6 commits into from
May 4, 2022

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Apr 27, 2022 •
edited
Loading

Description

Adding Circle CI and storybook builds for every PR

Related to: #24

Screen Shot 2022-04-27 at 11 47 22 AM

@metamaskbot
Copy link
Collaborator

Builds ready [d79894b]

@metamaskbot
Copy link
Collaborator

Builds ready [3180228]

@georgewrmarshall georgewrmarshall marked this pull request as ready for review April 27, 2022 18:50
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner April 27, 2022 18:50
@georgewrmarshall georgewrmarshall self-assigned this Apr 27, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [9ad133f]

Cal-L
Cal-L approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall merged commit bf0f3ce into main May 4, 2022
@georgewrmarshall georgewrmarshall deleted the circle-ci branch May 4, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@kumavis kumavis Awaiting requested review from kumavis

Assignees

@georgewrmarshall georgewrmarshall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgewrmarshall @metamaskbot @Cal-L