Remove BaseBlockTracker
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
remove-inheritance
branch
from
b37e79a
to
d256a0c
Compare
The base block tracker has been inlined into the polling block tracker and the subscribe block tracker. The base class has been removed. This was done to improve readability and allow for further simplications in later PRs. A `BlockTracker` type has been added to represent the common block tracker interface. This type can be used anywhere we might want to use a block tracker where we don't care which specific type it is.
Gudahtt
force-pushed
the
remove-inheritance
branch
from
d256a0c
to
a4bb2f8
Compare
mcmire
approved these changes
Jul 25, 2023
| this._synchronize(); | ||
| } | ||
|
|
||
| protected async _end(): Promise<void> { | ||
| private async _end(): Promise<void> { |
There was a problem hiding this comment.
Nit: Do we need this method? (If you wanted to remove this in a later step so that it's easy to see that there are no differences, that's fine)
There was a problem hiding this comment.
I don't think so! I tried to limit the scope of this PR though. I started going down the path of simplifying things, but ended up going too far so I scrapped it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base block tracker has been inlined into the polling block tracker and the subscribe block tracker. The base class has been removed. This was done to improve readability and allow for further simplications in later PRs.
A
BlockTrackertype has been added to represent the common block tracker interface. This type can be used anywhere we might want to use a block tracker where we don't care which specific type it is.