Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make intToHex produce valid Quantity #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josepot
Copy link

@josepot josepot commented Sep 1, 2022

Fixes #70

@josepot josepot requested a review from a team as a code owner September 1, 2022 10:54
@Gudahtt
Copy link
Member

Gudahtt commented Sep 7, 2022

Thanks for the contribution! Completely agree with the "Quantity" data type not having the leading zero, that is wrong, but there were some cases where the leading zero was required. Not within an RPC payload, but when the hex string is used for certain operations that expect the input to have an even length (so that each pair of digits can be used to represent one byte).

I'm unsure if that concern applies in this case. I'll audit the uses of the intToHex funciton to find out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intToHex util produces invalid Quantities
2 participants