Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo standardization #66

Merged
merged 1 commit into from Apr 5, 2021
Merged

Repo standardization #66

merged 1 commit into from Apr 5, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 5, 2021

  • Standardizing circleci config
  • Enforcing minimum node version 12 via .nvmrc, and the package file
  • Adding basic .gitattributes file
  • Updating readme to reference yarn over npm, formatting adjustment

Related: https://github.com/MetaMask/MetaMask-planning/issues/32

* Standardizing circleci config
* Enforcing minimum node version 12 via .nvmrc, and the package file
* Adding basic .gitattributes file
* Updating readme to reference yarn over npm, formatting adjustment
@ryanml ryanml self-assigned this Apr 5, 2021
@ryanml ryanml requested a review from a team as a code owner April 5, 2021 07:48
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanml ryanml merged commit d525991 into main Apr 5, 2021
@ryanml ryanml deleted the repo-standard branch April 5, 2021 21:32
@Gudahtt Gudahtt mentioned this pull request Apr 20, 2021
julianariel pushed a commit to block-wallet/eth-ledger-bridge-keyring that referenced this pull request Apr 27, 2022
* Standardizing circleci config
* Enforcing minimum node version 12 via .nvmrc, and the package file
* Adding basic .gitattributes file
* Updating readme to reference yarn over npm, formatting adjustment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants