Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 0.4.0 #69

Merged
merged 1 commit into from Apr 20, 2021
Merged

Update to 0.4.0 #69

merged 1 commit into from Apr 20, 2021

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Apr 20, 2021 •
edited

  • Includes the required wiring to allow switching between Ledger Live and U2F connections to the Ledger.
  • Upgrade of the ethereumjs-util library to 7.0.9
  • Renamed _isBIP44 to more intelligible _isLedgerLiveHdPath
  • Repo standardization which require minimum version of Node 12 and switch to yarn

@darkwing darkwing requested a review from a team as a code owner April 20, 2021 13:32
@darkwing darkwing requested a review from Gudahtt April 20, 2021 13:32
@Gudahtt
Copy link
Member

Gudahtt commented Apr 20, 2021

Looks good! It'd be great to get a list of changes for this version though, at least in the PR description (since there is no changelog)

@Gudahtt
Copy link
Member

Gudahtt commented Apr 20, 2021

The repo standardization in #66 bumped the minimum Node.js version. As a breaking change, that should definitely be reflected in the changelog.

@darkwing
Copy link
Contributor Author

Updated!

Gudahtt
Gudahtt approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkwing
Copy link
Contributor Author

  • Includes the required wiring to allow switching between Ledger Live and U2F connections to the Ledger.
  • Upgrade of the ethereumjs-util library to 7.0.9
  • Renamed _isBIP44 to more intelligible _isLedgerLiveHdPath
  • Repo standardization which require minimum version of Node 12 and switch to yarn

@darkwing darkwing merged commit 1f5d1a2 into MetaMask:main Apr 20, 2021
@Gudahtt
Copy link
Member

Gudahtt commented Apr 20, 2021

A new version of the package @metamask/eth-ledger-bridge-keyring (0.4.0) was published at 2021-04-20T17:18:35.383Z from
[redacted]. The shasum of this package was 764834adf146fc86ab7688a6c8f1e08708ed0d71.

julianariel pushed a commit to block-wallet/eth-ledger-bridge-keyring that referenced this pull request Apr 27, 2022
@darkwing
Update to 0.4.0 (MetaMask#69)
9cee679
Reclick55
Reclick55 reviewed Jan 5, 2023
View reviewed changes
Copy link

@Reclick55 Reclick55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How that possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reclick55 Reclick55 Reclick55 left review comments

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darkwing @Gudahtt @Reclick55