Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #13 #14

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Resolve #13 #14

merged 1 commit into from
Aug 15, 2017

Conversation

sdtsui
Copy link
Contributor

@sdtsui sdtsui commented Aug 15, 2017

No description provided.

@sdtsui sdtsui mentioned this pull request Aug 15, 2017
Closed
@danfinlay danfinlay merged commit c13d142 into MetaMask:master Aug 15, 2017
@danfinlay
Copy link
Contributor

Wait, why are we maintaining a separate blacklist from 409H? They had this listed an hour ago.

@danfinlay
Copy link
Contributor

Thanks so much for PR'ing this @sdtsui I didn't even know where this was yet.

@409H
Copy link
Collaborator

409H commented Aug 15, 2017

@FlySwatter I think the plan is for EAL to move over to use this blacklist logic - just haven't had time yet.

@sdtsui sdtsui deleted the patch-1 branch August 16, 2017 01:24
@409H 409H added the blocklist addition Issue or PR requesting addition of a domain to the blocklist label Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfinlay danfinlay danfinlay approved these changes

Assignees
No one assigned
Labels
blocklist addition Issue or PR requesting addition of a domain to the blocklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdtsui @danfinlay @409H