Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package files & metadata #81

Merged
merged 1 commit into from Jan 22, 2020
Merged

Conversation

whymarrh
Copy link
Contributor

Refs #79

This PR updates the package metadata, post TypeScript:

  • Add .editorconfig file
  • Add .gitattributes file
  • Update npm package structure (via .files in the package.json, diff below)

npm package structure

Before:

$ npm pack
npm notice 
npm notice 馃摝  eth-sig-util@2.5.2
npm notice === Tarball Contents === 
npm notice 790B   package.json          
npm notice 37B    circle.yml            
npm notice 17.1kB index.js              
npm notice 2.9kB  README.md             
npm notice 398B   .circleci/config.yml  
npm notice 35.5kB test/index.js         
npm notice 5.3kB  utils/eccrypto-lite.js
npm notice === Tarball Details === 
npm notice name:          eth-sig-util                            
npm notice version:       2.5.2                                   
npm notice filename:      eth-sig-util-2.5.2.tgz                  
npm notice package size:  13.4 kB                                 
npm notice unpacked size: 62.1 kB                                 
npm notice shasum:        42b5c3ef87f55db76e73dd3f7c482f0d42eb17d8
npm notice integrity:     sha512-9WPFX01ILINqW[...]dXZedLamAzMZQ==
npm notice total files:   7                                       
npm notice 

Which is confirmed on a fresh download from npm:

$ la node_modules/eth-sig-util/
total 64 
-rw-r--r-- 1 README.md
-rw-r--r-- 1 circle.yml
-rw-r--r-- 1 index.js
-rw-r--r-- 1 package.json
drwxr-xr-x 3 test
drwxr-xr-x 3 utils

After:

$ npm pack
npm notice 
npm notice 馃摝  eth-sig-util@2.5.2
npm notice === Tarball Contents === 
npm notice 1.0kB  package.json          
npm notice 7.2kB  index.d.ts            
npm notice 20.4kB index.js              
npm notice 2.8kB  README.md             
npm notice 5.3kB  utils/eccrypto-lite.js
npm notice === Tarball Details === 
npm notice name:          eth-sig-util                            
npm notice version:       2.5.2                                   
npm notice filename:      eth-sig-util-2.5.2.tgz                  
npm notice package size:  8.3 kB                                  
npm notice unpacked size: 36.8 kB                                 
npm notice shasum:        da03834127ce49a1f6426588026267eb477a2084
npm notice integrity:     sha512-xaCswPeX2c5Ln[...]Dps0xev46J6KQ==
npm notice total files:   5                                       
npm notice 

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit a67ae70 into MetaMask:master Jan 22, 2020
@whymarrh whymarrh deleted the package-files branch January 22, 2020 23:23
Gudahtt added a commit that referenced this pull request Feb 3, 2021
This is a backport of #81, to before the TypeScript migration took
place.
Gudahtt added a commit that referenced this pull request Feb 3, 2021
This is a backport of #81, to before the TypeScript migration took
place.
Gudahtt added a commit that referenced this pull request Feb 3, 2021
This is a backport of #81, to before the TypeScript migration took
place.
Gudahtt added a commit that referenced this pull request Feb 3, 2021
This is a backport of #81, to before the TypeScript migration took
place.
Gudahtt added a commit that referenced this pull request Feb 4, 2021
This is a backport of #81, to before the TypeScript migration took
place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants