Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interactive UI documentation #1166

Merged
merged 30 commits into from Mar 28, 2024
Merged

Add interactive UI documentation #1166

merged 30 commits into from Mar 28, 2024

Conversation

ziad-saab
Copy link
Contributor

No description provided.

@ziad-saab ziad-saab requested review from a team as code owners February 22, 2024 20:45
@ziad-saab ziad-saab marked this pull request as draft February 22, 2024 20:45
@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

1 similar comment
@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

1 similar comment
@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@Montoya
Copy link
Contributor

Montoya commented Feb 24, 2024

How do we get another preview published?

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

GuillaumeRx
GuillaumeRx reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update snap_dialog, onTransaction, onSignature and onHomePage documentation to tell that they can pass the id key with the interface ID.

snaps/features/custom-ui.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@alexandratran
Copy link
Contributor

alexandratran commented Mar 20, 2024 •
edited

Made some edits for style and clarity, and added context to the examples. See my previous comments for outstanding questions.

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@alexandratran
Merge branch 'main' into zs/interactive-ui
7521077 
# Conflicts:
#	snaps/features/custom-ui/index.md
@alexandratran
fix link
74510e6
@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

alexandratran
alexandratran approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional minor edits and rearranged interactive UI methods in the Snaps API reference to clarify that those methods don't require requesting permission in the manifest file. LGTM

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@ziad-saab
Copy link
Contributor Author

Still waiting on an answer about label before merging

Montoya
Montoya previously requested changes Mar 22, 2024
View reviewed changes
snaps/features/custom-ui/interactive-ui.md Outdated Show resolved Hide resolved
@ziad-saab ziad-saab requested a review from Montoya March 22, 2024 22:42
@ziad-saab ziad-saab dismissed Montoya’s stale review March 22, 2024 22:42

request re-review

@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@alexandratran
Merge branch 'main' into zs/interactive-ui
9e5c99c 
# Conflicts:
#	snaps/index.mdx
#	snaps/reference/entry-points.md
#	snaps/reference/snaps-api.md
@alexandratran
fix links
bd43167
@github-actions GitHub Actions
Copy link

Preview published: zs/interactive-ui

@alexandratran alexandratran merged commit 2860a35 into main Mar 28, 2024
8 checks passed
@alexandratran alexandratran deleted the zs/interactive-ui branch March 28, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montoya Montoya Montoya approved these changes

@alexandratran alexandratran alexandratran approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

Assignees

@alexandratran alexandratran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ziad-saab @Montoya @alexandratran @GuillaumeRx